-
Notifications
You must be signed in to change notification settings - Fork 44
Simplify Symbology of Vectors #672
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Simplify Symbology of Vectors #672
Conversation
Integration tests report: appsharing.space |
Hello @mfisher87, can you please try reproducing your issue on this branch? |
It may be a couple days; sprinting for a workshop on Wednesday. But yes, I will test it! If needed, please remind me, it won't bother me :) |
No hurry. Thanks for the heads up |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great!
You will need to update the GISDocument's Python API as well, removing the vector layers type
packages/base/src/dialogs/symbology/vector_layer/types/SimpleSymbol.tsx
Outdated
Show resolved
Hide resolved
Co-authored-by: Greg Mooney <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Description
Maybe fix #597 & #469
sample-sym.mp4
symbology.mp4
Checklist
Resolves #XXX
.Failing lint checks can be resolved with:
pre-commit run --all-files
jlpm run lint
📚 Documentation preview: https://jupytergis--672.org.readthedocs.build/en/672/
💡 JupyterLite preview: https://jupytergis--672.org.readthedocs.build/en/672/lite