Skip to content

Simplify Symbology of Vectors #672

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
May 14, 2025

Conversation

arjxn-py
Copy link
Member

@arjxn-py arjxn-py commented Apr 30, 2025

Description

Maybe fix #597 & #469

sample-sym.mp4
symbology.mp4

Checklist

  • PR has a descriptive title and content.
  • PR description contains references to any issues the PR resolves, e.g. Resolves #XXX.
  • PR has one of the labels: documentation, bug, enhancement, feature, maintenance
  • Checks are passing.
    Failing lint checks can be resolved with:
    • pre-commit run --all-files
    • jlpm run lint

📚 Documentation preview: https://jupytergis--672.org.readthedocs.build/en/672/
💡 JupyterLite preview: https://jupytergis--672.org.readthedocs.build/en/672/lite

Copy link
Contributor

Binder 👈 Launch a Binder on branch arjxn-py/jupytergis/simplify-symbology-panel

Copy link
Contributor

github-actions bot commented Apr 30, 2025

Integration tests report: appsharing.space

@arjxn-py arjxn-py added the enhancement New feature or request label May 4, 2025
@arjxn-py
Copy link
Member Author

Hello @mfisher87, can you please try reproducing your issue on this branch?

@arjxn-py arjxn-py marked this pull request as ready for review May 12, 2025 22:14
@arjxn-py arjxn-py changed the title [WIP]: Simplify Symbology of Vectors Simplify Symbology of Vectors May 12, 2025
@mfisher87
Copy link
Member

It may be a couple days; sprinting for a workshop on Wednesday. But yes, I will test it! If needed, please remind me, it won't bother me :)

@arjxn-py
Copy link
Member Author

It may be a couple days; sprinting for a workshop on Wednesday. But yes, I will test it! If needed, please remind me, it won't bother me :)

No hurry. Thanks for the heads up
Good wishes for the workshop :)

Copy link
Member

@martinRenou martinRenou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

You will need to update the GISDocument's Python API as well, removing the vector layers type

@arjxn-py arjxn-py requested a review from martinRenou May 13, 2025 11:29
@arjxn-py arjxn-py requested review from martinRenou and gjmooney May 14, 2025 07:56
Copy link
Member

@martinRenou martinRenou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@martinRenou martinRenou merged commit 3c71f21 into geojupyter:main May 14, 2025
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can't apply colormap to embedded or remote GeoJSON data source Confusing UX when changing symbology and wrong "source type" selected
4 participants